posthog icon indicating copy to clipboard operation
posthog copied to clipboard

chore: use meta columns in data visualization table

Open daibhin opened this issue 4 months ago • 3 comments

Problem

The DataVisualizationNode relies on a Table component that is not DataTable. In recent work to improve the HogQLX component for recordings I couldn't update the column title because Table didn't use the same renderColumnMeta as DataTable. This also means that any align and width properties set in the context are ignored.

I don't fully understand the need for custom table. Maybe we can double back and clean that up in time. I'd be worried these two implementations continue to drift otherwise. For now this is enough to keep things in step.

Changes

Title of the "Recording Button" column is much better

Before After
Screenshot 2024-10-18 at 18 12 37 Screenshot 2024-10-18 at 18 12 08

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

By eye

daibhin avatar Oct 18 '24 17:10 daibhin