posthog icon indicating copy to clipboard operation
posthog copied to clipboard

ci: add tach

Open caelean opened this issue 1 year ago • 1 comments

Problem

For developers, it's often easy to co-opt code and use it outside of its intended original purpose. This creates a brittle dependency which over time creates a codebase that is much harder to both reason about and change. This has downstream impact on CI/CD runtime, tooling, and developer velocity.

The solution to this is to isolate code to its intended scope. Python does a very poor job of providing tools to do this, which is where tach can be helpful. https://docs.gauge.sh/getting-started/why-tach

Changes

  • Add tach to requirements-dev
  • Add minimal configuration to tach.toml, wrapping the (newer) warehouse module
  • Add tach check to ci-backend.yml under backend-code-quality

Does this work well for both Cloud and self-hosted?

No impact

How did you test this code?

CI

caelean avatar Oct 10 '24 00:10 caelean

image

caelean avatar Oct 15 '24 22:10 caelean

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

posthog-bot avatar Oct 30 '24 07:10 posthog-bot

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

posthog-bot avatar Nov 07 '24 07:11 posthog-bot