posthog icon indicating copy to clipboard operation
posthog copied to clipboard

feat: Add new CDP sources such as activity log and alerts

Open benjackwhite opened this issue 1 year ago â€ĸ 9 comments

Problem

We want to be able to trigger hog functions off a mixture of different sources. Primarily this is intended for Alerts but also things like Activity log entries or possibly Exception group based alerts (that will be a different source than the standard events ingestion.

Could even (one day) have pre-ingestion events as a source (Hog Transformations!)

Changes

  • [ ] Adds a new source field that can be used as a way of filtering HogFunctions for different source cases
  • [ ] The new source types also have related triggers
  • [ ] Feature flagged so we can test it first

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

benjackwhite avatar Sep 23 '24 14:09 benjackwhite

Size Change: 0 B

Total Size: 1.1 MB

â„šī¸ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.1 MB

compressed-size-action

github-actions[bot] avatar Sep 23 '24 14:09 github-actions[bot]

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Sep 23 '24 14:09 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Sep 23 '24 15:09 posthog-bot

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Sep 24 '24 07:09 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Sep 24 '24 08:09 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Sep 24 '24 08:09 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Sep 24 '24 08:09 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

posthog-bot avatar Oct 08 '24 07:10 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

posthog-bot avatar Oct 17 '24 07:10 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

posthog-bot avatar Oct 25 '24 07:10 posthog-bot

The work in https://github.com/PostHog/posthog/pull/25719 (and its spinoff PRs) can/could/should be reused here. Namely the hog functions now have a type enum, which also includes activity and alert as two types (alongside destination, email and broadcast)

mariusandra avatar Oct 25 '24 10:10 mariusandra

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

posthog-bot avatar Nov 04 '24 07:11 posthog-bot

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

posthog-bot avatar Nov 11 '24 07:11 posthog-bot