posthog icon indicating copy to clipboard operation
posthog copied to clipboard

chore: convert simple / advanced filters to universal if enabled

Open daibhin opened this issue 1 year ago â€ĸ 2 comments

Problem

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

daibhin avatar Jun 27 '24 18:06 daibhin

@pauldambra there is still a bit of work left in this one but this is the converter that allows us to enable the new universal filters in production. It basically flips us from a world where simple / advanced filters were expected to one where universal filters are the default.

Will spend tomorrow testing this out and making sure everything works with the flag enabled / disabled but wanted to give you a heads up for review purposes

daibhin avatar Jun 27 '24 18:06 daibhin

Size Change: +200 B (+0.02%)

Total Size: 1.07 MB

â„šī¸ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.07 MB +200 B (+0.02%)

compressed-size-action

github-actions[bot] avatar Jun 27 '24 18:06 github-actions[bot]

Hey @daibhin! 👋 This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

posthog-bot avatar Jul 02 '24 10:07 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jul 02 '24 10:07 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jul 02 '24 10:07 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jul 02 '24 11:07 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jul 02 '24 11:07 posthog-bot