posthog icon indicating copy to clipboard operation
posthog copied to clipboard

chore(data-warehouse): Added number formatting for source settings

Open Gilbert09 opened this issue 1 year ago â€ĸ 3 comments

Problem

  • Lack of commas in numbers were annoying me

Changes

Format rows synced numbers with commas

image

Does this work well for both Cloud and self-hosted?

Yep

How did you test this code?

👀

Gilbert09 avatar Jun 25 '24 10:06 Gilbert09

Size Change: 0 B

Total Size: 1.06 MB

â„šī¸ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.06 MB

compressed-size-action

github-actions[bot] avatar Jun 25 '24 10:06 github-actions[bot]

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jun 27 '24 20:06 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jun 27 '24 20:06 posthog-bot

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jul 02 '24 13:07 posthog-bot