posthog
posthog copied to clipboard
feat(insights): multiple breakdowns in trends
Problem
This PR adds multiple breakdowns support to InsightsQuery, ActorsQuery, and InsightActorsQueryOptions.
Closes #938 and #23156
Breakdown by before changes
Multiple breakdowns
Demo
Actors queries
Breakdown options
đ¸ UI snapshots have been updated
6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
chromium: 0 added, 4 modified, 0 deleted (diff for shard 2)webkit: 0 added, 2 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
18 snapshot changes in total. 0 added, 18 modified, 0 deleted:
chromium: 0 added, 0 modified, 0 deletedwebkit: 0 added, 18 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
18 snapshot changes in total. 0 added, 18 modified, 0 deleted:
chromium: 0 added, 18 modified, 0 deleted (diff for shard 2)webkit: 0 added, 0 modified, 0 deleted
Triggered by this commit.
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)webkit: 0 added, 0 modified, 0 deleted
Triggered by this commit.
Size Change: +42 B (0%)
Total Size: 1.07 MB
âšī¸ View Unchanged
| Filename | Size | Change |
|---|---|---|
frontend/dist/toolbar.js |
1.07 MB | +42 B (0%) |
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)webkit: 0 added, 0 modified, 0 deleted
Triggered by this commit.
đ¸ UI snapshots have been updated
38 snapshot changes in total. 0 added, 38 modified, 0 deleted:
chromium: 0 added, 20 modified, 0 deleted (diff for shard 2)webkit: 0 added, 18 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
16 snapshot changes in total. 0 added, 16 modified, 0 deleted:
chromium: 0 added, 0 modified, 0 deletedwebkit: 0 added, 16 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
10 snapshot changes in total. 0 added, 10 modified, 0 deleted:
chromium: 0 added, 6 modified, 0 deleted (diff for shard 1, diff for shard 2)webkit: 0 added, 4 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
Wow @skoob13 this is amazing! I can't believe this is basically your second PR? What a starter project.
Is this entirely feature flagged? If so, I wouldn't mind getting it out sooner than later and being able to investigate production data with it.
Started to take a cursory look and play around with it. One (minor) thing I noticed is that it doesn't respect breakdown limit with multiple numerics (although multiple numerics is such a crazy case and so unusable for any real analysis as is, we'd probably want to design a whole new data visualization for that - it might be okay to limit to one numeric for now, although if it works nobody would complain)
One (minor) thing I noticed is that it doesn't respect breakdown limit with multiple numerics
@aspicer nice catch! I fixed it.
Is this entirely feature flagged? If so, I wouldn't mind getting it out sooner than later and being able to investigate production data with it.
It is feature flagged but not entirely. The PR still affects the current breakdown implementation in Trends. When the flag is enabled, it uses breakdown arrays. Otherwise, it uses the current filter structure.
đ¸ UI snapshots have been updated
2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)webkit: 0 added, 0 modified, 0 deleted
Triggered by this commit.