posthog icon indicating copy to clipboard operation
posthog copied to clipboard

feat(insights): multiple breakdowns in trends

Open skoob13 opened this issue 1 year ago â€ĸ 10 comments

Problem

This PR adds multiple breakdowns support to InsightsQuery, ActorsQuery, and InsightActorsQueryOptions.

Closes #938 and #23156

Breakdown by before changes

single_breakdown

Multiple breakdowns

Demo

multiple_breakdowns

Actors queries

multiple_breakdowns_actors

Breakdown options

multiple_breakdowns_options

skoob13 avatar Jun 21 '24 16:06 skoob13

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jun 25 '24 09:06 posthog-bot

📸 UI snapshots have been updated

18 snapshot changes in total. 0 added, 18 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 18 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jun 25 '24 17:06 posthog-bot

📸 UI snapshots have been updated

18 snapshot changes in total. 0 added, 18 modified, 0 deleted:

  • chromium: 0 added, 18 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jun 25 '24 17:06 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jun 26 '24 14:06 posthog-bot

Size Change: +42 B (0%)

Total Size: 1.07 MB

â„šī¸ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.07 MB +42 B (0%)

compressed-size-action

github-actions[bot] avatar Jun 26 '24 14:06 github-actions[bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jun 26 '24 14:06 posthog-bot

📸 UI snapshots have been updated

38 snapshot changes in total. 0 added, 38 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jun 27 '24 15:06 posthog-bot

📸 UI snapshots have been updated

16 snapshot changes in total. 0 added, 16 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 16 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jun 28 '24 10:06 posthog-bot

📸 UI snapshots have been updated

10 snapshot changes in total. 0 added, 10 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jun 28 '24 11:06 posthog-bot

Wow @skoob13 this is amazing! I can't believe this is basically your second PR? What a starter project.

Is this entirely feature flagged? If so, I wouldn't mind getting it out sooner than later and being able to investigate production data with it.

Started to take a cursory look and play around with it. One (minor) thing I noticed is that it doesn't respect breakdown limit with multiple numerics (although multiple numerics is such a crazy case and so unusable for any real analysis as is, we'd probably want to design a whole new data visualization for that - it might be okay to limit to one numeric for now, although if it works nobody would complain) image

aspicer avatar Jun 28 '24 16:06 aspicer

One (minor) thing I noticed is that it doesn't respect breakdown limit with multiple numerics

@aspicer nice catch! I fixed it.

Is this entirely feature flagged? If so, I wouldn't mind getting it out sooner than later and being able to investigate production data with it.

It is feature flagged but not entirely. The PR still affects the current breakdown implementation in Trends. When the flag is enabled, it uses breakdown arrays. Otherwise, it uses the current filter structure.

skoob13 avatar Jul 01 '24 12:07 skoob13

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Jul 08 '24 16:07 posthog-bot