posthog icon indicating copy to clipboard operation
posthog copied to clipboard

fix: Enabling plugins + destinations gating

Open tiina303 opened this issue 1 year ago â€ĸ 3 comments

Problem

Enabling plugins was broken because enabled was pulled out of the formData, so if was always added as false. Destinations weren't gated by data-pipelines add-on

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Verified that I can now enable/disable plugins. Destinations creation pages showed upgrade option and toggles as well.

tiina303 avatar May 20 '24 14:05 tiina303

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar May 20 '24 15:05 posthog-bot

Size Change: 0 B

Total Size: 1.05 MB

â„šī¸ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.05 MB

compressed-size-action

github-actions[bot] avatar May 20 '24 15:05 github-actions[bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar May 20 '24 15:05 posthog-bot