posthog icon indicating copy to clipboard operation
posthog copied to clipboard

feat(insights): add not loaded empty state

Open thmsobrmlr opened this issue 1 year ago • 2 comments

Problem

Insights that haven't loaded data yet are displayed as empty.

Changes

This adds a "no data yet" empty state

Todos:

  • [ ] Add for all viz types (see displayMap in InsightCard)
  • [ ] Add tests
  • [ ] Refactor this into a HOC?

How did you test this code?

Used FLUSHDB in redis-cli + reload

thmsobrmlr avatar May 17 '24 17:05 thmsobrmlr

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar May 17 '24 17:05 posthog-bot

Size Change: 0 B

Total Size: 1.05 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.05 MB

compressed-size-action

github-actions[bot] avatar May 17 '24 17:05 github-actions[bot]

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar May 27 '24 07:05 posthog-bot

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

posthog-bot avatar Jun 03 '24 07:06 posthog-bot