posthog icon indicating copy to clipboard operation
posthog copied to clipboard

feat: allow event session property filters in replay

Open pauldambra opened this issue 1 year ago â€ĸ 4 comments

Since we're using HogQL and property_to_expr we can allow session property filtering when filtering events in session replay

(we should totally allow this at the top level but for now this is a hogql only feature to let us prove the value a little more)

pauldambra avatar May 12 '24 12:05 pauldambra

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: posthog/hogql/property.py

Function Unhandled Issue
property_to_expr Cohort.DoesNotExist: Cohort matching query does not exist. posthog.tasks.tasks.process_...
Event Count: 12
property_to_expr NotImplementedError: property_to_expr for element selector only supports exact and is_not operators, not regex ...
Event Count: 4

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar May 12 '24 12:05 sentry[bot]

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar May 12 '24 12:05 posthog-bot

Size Change: 0 B

Total Size: 1.05 MB

â„šī¸ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.05 MB

compressed-size-action

github-actions[bot] avatar May 12 '24 12:05 github-actions[bot]

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar May 12 '24 12:05 posthog-bot