posthog icon indicating copy to clipboard operation
posthog copied to clipboard

fix: Pipeline node logs kea logic types

Open tiina303 opened this issue 1 year ago • 1 comments

Problem

This was the only logic with different way to use loaders and it was also wrong, the type of PluginLogEntry[] | BatchExportLogEntry[] is not the same as (BatchExportLogEntry | BatchExportLogEntry)[].

There was a typing error in the app source code file too, not sure who fixed prettier or what changed.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

tiina303 avatar May 10 '24 15:05 tiina303

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar May 20 '24 07:05 posthog-bot

Size Change: -14.8 kB (-1.41%)

Total Size: 1.03 MB

Filename Size Change
frontend/dist/toolbar.js 1.03 MB -14.8 kB (-1.41%)

compressed-size-action

github-actions[bot] avatar May 23 '24 13:05 github-actions[bot]