posthog icon indicating copy to clipboard operation
posthog copied to clipboard

feat: Ability to show plugin developers commitHash in UI

Open tiina303 opened this issue 9 months ago • 2 comments

Problem

Plugin developers to test in our cloud need to have us update the plugin, there's no way for them to see what version it's running, so sometimes they will ask, instead we can use log level 0 for them and include that info in the setup message.

Request: https://posthog.slack.com/archives/C05M3SMFSAG/p1715085765245699

Changes

  1. added commitHash to pod logs and to plugin setup log
  2. can update plugin in django admin (blank=True), since it's manyToMany it doesn't change anything
  3. can override logLEvel to 0 (|| -> ??)
  4. Removed single organization self-replication allowed since the app has been disabled for them (unrelated clean-up, just because I was there)

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

saw in logs:

🔌 setupPlugin succeeded for plugin Taxonomy Plugin ID 4 (organization ID 018e628e-99d7-0000-ff0b-1c5490bdc38f - global - tag 21215eace23e3a89058cf1774dc54c65b4c96dff).

Screenshot 2024-05-09 at 16 06 42

tiina303 avatar May 09 '24 14:05 tiina303

A test needs updating: https://github.com/PostHog/posthog/actions/runs/9018992960/job/24780853603?pr=22225#step:14:281

bretthoerner avatar May 15 '24 04:05 bretthoerner

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar May 22 '24 07:05 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar Jun 05 '24 07:06 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar Jun 14 '24 07:06 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar Jun 24 '24 07:06 posthog-bot

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

posthog-bot avatar Jul 02 '24 07:07 posthog-bot

Going with the inlining plugins route instead

tiina303 avatar Jul 09 '24 12:07 tiina303