posthog icon indicating copy to clipboard operation
posthog copied to clipboard

fix(plugin-server): assert fields we iterate over are objects

Open bretthoerner opened this issue 1 year ago • 1 comments

This is a WIP that will require tests to be updated if we actually want to merge it.

However, it [seems to me that capture-rs will reject events] if the user sends a string as the toplevel properties, $set, or $set_once. We could just add an assertion for properties.$set and properties.$set_once and reject those events too, which seems cleaner...

Anyone have opinions on whether we should just reject these events as misshapen in capture?

Worth noting that Python capture definitely doesn't require (or check) that these are objects, to our detriment: https://posthog.sentry.io/issues/5321764413/

bretthoerner avatar May 08 '24 20:05 bretthoerner

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar May 16 '24 07:05 posthog-bot

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

posthog-bot avatar May 24 '24 07:05 posthog-bot