posthog icon indicating copy to clipboard operation
posthog copied to clipboard

chore(data-warehouse): Condensed joins UI

Open Gilbert09 opened this issue 1 year ago â€ĸ 4 comments

Problem

  • We had tabs in the data warehouse scene, one for the tables and another for managing joins
  • We want to move the warehouse stuff into data pipelines 3000, and so getting rid of the joins tab would make the transition much easier

Changes

  • Condensed the joins UI and logic into the tables views
  • Can edit and delete joins from the table (from the individual columns)
    • Works on both posthog and warehouse tables
  • Removed the Joins tab and relevant components

https://github.com/PostHog/posthog/assets/1459269/61e0da23-dcec-4d2e-82ae-2b71c8ba5550

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Browser clicks

Gilbert09 avatar May 08 '24 15:05 Gilbert09

Size Change: 0 B

Total Size: 1.05 MB

â„šī¸ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.05 MB

compressed-size-action

github-actions[bot] avatar May 08 '24 15:05 github-actions[bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar May 08 '24 15:05 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar May 08 '24 15:05 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar May 17 '24 07:05 posthog-bot