fix(insights): Make query based insights show better
Problem
Insights that are query based directly from the start show up with additional controls on the dashboard.
Changes
- pass down
embeddedprop better and handle it accordingly - add snapshots for this type of insight
- fix loading in certain states: when cache is available but no filters present, one util was preventing the insight from showing up without any additional requests
Before
After
Does this work well for both Cloud and self-hosted?
n/a
How did you test this code?
- added snapshots
- how to test:
- create insight with query based structure and no filters at all
- edit it via database if necessary
- look at dashboard
Size Change: 0 B
Total Size: 1.05 MB
ℹ️ View Unchanged
| Filename | Size |
|---|---|
frontend/dist/toolbar.js |
1.05 MB |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.
@thmsobrmlr Maybe you also check this here, since you have a PR on a similar topic.
@thmsobrmlr Maybe you also check this here, since you have a PR on a similar topic.
Oh yeah, this does look pretty much like it's the same as https://github.com/PostHog/posthog/pull/22400. Will have a deeper look tomorrow, but likely only one of them should go in. There shouldn't be any query based insights in prod, so I don't think we need to rush it.
Closing in favor of #22400