posthog icon indicating copy to clipboard operation
posthog copied to clipboard

chore: split Persons using deterministic uuid

Open bretthoerner opened this issue 1 year ago • 1 comments

Problem

No problem, per say, but I discussed with @tiina303 and one benefit of using deterministic Person UUIDs is that we can split distinct_ids back out to their original Person UUID, and drop an override for them, and things should just work.

Changes

Use the deterministic UUID for Person rows in split_person

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Existing

bretthoerner avatar May 06 '24 19:05 bretthoerner

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar May 15 '24 07:05 posthog-bot

@tiina303 This is ready, I checked and all other PRs are failing with this (totally unrelated) Django test failure.

bretthoerner avatar Jun 07 '24 22:06 bretthoerner