posthog icon indicating copy to clipboard operation
posthog copied to clipboard

fix(api): Update query API comments for docs

Open ivanagas opened this issue 1 year ago • 4 comments

Problem

Although the query API is maybe our most important endpoint, our docs don't reflect that. Beginning to update them to fix that.

Changes

Updating events, query, and persons endpoint to clarify what the purpose of query endpoint is and cleanup. For example:

Old: CleanShot 2024-05-03 at 16 47 45@2x

New: CleanShot 2024-05-03 at 16 45 35@2x

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

It doesn't have an impact.

How did you test this code?

Ran locally with redoc and swagger (although the various DRF formats don't always show well).

ivanagas avatar May 03 '24 23:05 ivanagas

I'm going to keep working on this next week, so let me know if there is any areas you know of that need improving :)

ivanagas avatar May 03 '24 23:05 ivanagas

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar May 04 '24 00:05 posthog-bot

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar May 04 '24 00:05 posthog-bot

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar May 04 '24 00:05 posthog-bot

Did more digging, this isn't going to work the way I wanted it to :(

ivanagas avatar May 08 '24 23:05 ivanagas