posthog icon indicating copy to clipboard operation
posthog copied to clipboard

Rewrite replay filtering as HogQL filters

Open pauldambra opened this issue 1 year ago • 1 comments

in order of increasing exciteability

  • [x] Ensure date clamps on joined tables in hoqgl
  • [x] Port each filter directly to hogql
    • [x] Person properties
    • [x] ~~(Any top level property)~~ we don't have the UI to do any property so that's not a direct port
    • [x] Events (with filters)
      • [x] Some timestamp clamping needs fixing
    • [x] Actions (with filters)
    • [x] Cohorts
    • [x] Group properties?
    • [x] Console log text
    • [x] Console log level
    • [x] Time
    • [x] Duration
    • [x] Internal/test account filters
    • [x] Ordering
    • [x] Paging
      • [x] Looks like there’s an existing paginator class we can re-use
  • [x] Measure performance with flag on and off in prod
  • [x] session properties support
  • [ ] Look at whether we can steal insight filter UI directly (ish) once we’ve got hogql running
  • [ ] can we use the same query generator for the events subquery as the activity page?
  • [ ] Screenshot or e2e tests of this UI
  • [ ] Put session replay thingies in taxonomic filter
  • [ ] Put magic filters as a front page of the taxonomic filter

pauldambra avatar May 02 '24 22:05 pauldambra

see zendesk https://posthoghelp.zendesk.com/agent/tickets/13257 which looks like a bug (pre-hogql) filtering recordings by an action that filters on "all events"

pauldambra avatar May 07 '24 18:05 pauldambra

As part of this work we should make Replay filters much more powerful, ideas include:

  • And / Or filtering groups
  • Multiple duration filters (e.g. > 10s, and < 1h)
  • Unified console log filters

Tasks

  • [x] Add "event occurred" filter to PropertyFilters https://github.com/PostHog/posthog/pull/22592
  • [x] Add "console log" filter to PropertyFilters
  • [x] Add Replay tab to TaxonomicFilter
  • [x] Allow 1 level of filter group nesting

daibhin avatar May 30 '24 14:05 daibhin

Think we've achieved pretty much everything we wanted to here. We're certainly back to where we were pre HogQL rewrite in terms of functionality and performance, and probably ahead in UX & some functionality. Going to close this one out and we can open new issues as needed

daibhin avatar Sep 02 '24 10:09 daibhin