posthog icon indicating copy to clipboard operation
posthog copied to clipboard

fix(hogql): fix trends actors with monthly active users aggregation

Open thmsobrmlr opened this issue 1 year ago • 1 comments
trafficstars

Problem

https://posthoghelp.zendesk.com/agent/tickets/12749 trends persons modal (cannot redefine actor_id)

It's not possible to get the actors of a trends query with monthly active users series (and potentially other aggregations).

Changes

Todos

  • [x] Add test
  • [ ] Fix new error "Unable to resolve field: timestamp"

How did you test this code?

thmsobrmlr avatar Apr 30 '24 16:04 thmsobrmlr

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: posthog/hogql_queries/insights/trends/trends_query_builder.py

Function Unhandled Issue
_get_events_subquery ValueError: could not convert string to float: '[2876.0,3177.01]' posthog.tasks.tasks.p...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar Apr 30 '24 16:04 sentry[bot]

Closing in favor of https://github.com/PostHog/posthog/pull/22132

thmsobrmlr avatar May 13 '24 12:05 thmsobrmlr