posthog icon indicating copy to clipboard operation
posthog copied to clipboard

feat(web-analytics): Rename initial session properties from "Initial X" to "Session X"

Open robbie-c opened this issue 1 year ago â€ĸ 8 comments

Problem

Spot the difference (one is using person props, the other session pros) image

Internal thread: https://posthog.slack.com/archives/C06R39WNY5B/p1714475094508139?thread_ts=1714474192.508889&cid=C06R39WNY5B

Changes

Make the session props look like "Session UTM source".

I also considered changing the icon for person/session/etc props, but not everywhere where this text is used has an icon

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Screenshot: Screenshot 2024-04-30 at 12 21 07

robbie-c avatar Apr 30 '24 11:04 robbie-c

Size Change: +74 B (0%)

Total Size: 1.05 MB

â„šī¸ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.05 MB +74 B (0%)

compressed-size-action

github-actions[bot] avatar Apr 30 '24 11:04 github-actions[bot]

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Apr 30 '24 17:04 posthog-bot

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Apr 30 '24 17:04 posthog-bot

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 2 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Apr 30 '24 21:04 posthog-bot

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Apr 30 '24 21:04 posthog-bot

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Apr 30 '24 22:04 posthog-bot

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar May 01 '24 09:05 posthog-bot

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar May 01 '24 09:05 posthog-bot