PostHog
ci: Run core backend tests with both HogQL and legacy insights
Changes
Let's make the HogQL engine the default. Still leaving a strategy with the legacy engine running.
This will allow us to catch problems in the saved insights/dashboards layer, and later on when converting /insight/{trend,funnel,etc}.
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.
As for /insight/{trend,funnel,etc}, the issue is that we definitely want to throw out the code of legacy insights, and these run-filters-ad-hoc endpoints are a blocker in their current state. There are two paths that I see right now:
- We just remove them – but it's certain that there are users somewhere with cron jobs or whatever programmed to get data out of PostHog by hitting these endpoints. Pulling the plug would cause those users massive pain.
- We keep the endpoints, but wrap them all in
filters_to_query(). The legacy code gets the boot, while API users are (generally) unharmed.
What do you think @thmsobrmlr? Let me know if you have an idea to refine this