posthog icon indicating copy to clipboard operation
posthog copied to clipboard

feat: Add migration in advance of session properties PR - Part 2/2

Open robbie-c opened this issue 1 year ago • 1 comments

Problem

Previous migration (here https://github.com/PostHog/posthog/pull/21703) was part 1 of 2

Changes

Run a migration to validate the previously unvalidated constraint. More info here https://www.postgresql.org/docs/current/sql-altertable.html#SQL-ALTERTABLE-NOTES but this only gets a SHARE UPDATE EXCLUSIVE lock, which means that this doesn't prevent inserts/updates.

Does this work well for both Cloud and self-hosted?

yes

How did you test this code?

ran the migration locally, plus tests pass :)

robbie-c avatar Apr 23 '24 20:04 robbie-c

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar May 02 '24 07:05 posthog-bot

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

posthog-bot avatar May 09 '24 07:05 posthog-bot