posthog
posthog copied to clipboard
feat(poersons-on-events): Add option to use new overrides with properties-on-events
Problem
We want to deprecate the old v2 person_overrides
used by person_id_override_properties_on_events
and replace it with v3 person_distinct_id_overrides
.
Changes
- Renames old internal mode identifier to
person_id_override_properties_on_events_deprecated
. - Refactors flag evaluation to reduce boilerplate.
- Adds new
person_id_override_properties_on_events
mode controlled bypersons-on-events-person-id-override-properties-on-events
.
Does this work well for both Cloud and self-hosted?
Yes, should not have any effect on self-hosted.
How did you test this code?
TODO: add tests for new mode
Size Change: 0 B
Total Size: 1.01 MB
âšī¸ View Unchanged
Filename | Size |
---|---|
frontend/dist/toolbar.js |
1.01 MB |
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
-
chromium
: 0 added, 1 modified, 0 deleted (diff for shard 2) -
webkit
: 0 added, 0 modified, 0 deleted
Triggered by this commit.
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
-
chromium
: 0 added, 1 modified, 0 deleted (diff for shard 2) -
webkit
: 0 added, 0 modified, 0 deleted
Triggered by this commit.
đ¸ UI snapshots have been updated
2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
-
chromium
: 0 added, 2 modified, 0 deleted (diff for shard 2) -
webkit
: 0 added, 0 modified, 0 deleted
Triggered by this commit.
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
-
chromium
: 0 added, 1 modified, 0 deleted (diff for shard 2) -
webkit
: 0 added, 0 modified, 0 deleted
Triggered by this commit.
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
-
chromium
: 0 added, 1 modified, 0 deleted (diff for shard 2) -
webkit
: 0 added, 0 modified, 0 deleted
Triggered by this commit.
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
-
chromium
: 0 added, 1 modified, 0 deleted (diff for shard 2) -
webkit
: 0 added, 0 modified, 0 deleted
Triggered by this commit.
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale
label â otherwise this will be closed in another week.
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.