posthog icon indicating copy to clipboard operation
posthog copied to clipboard

chore: replace icons with package equivalents

Open daibhin opened this issue 1 year ago • 8 comments

Problem

We currently have a lot of duplicate icons

Changes

Remove some of the old lemon-ui/icons/icons.tsx for their @posthog/icons counterparts

How did you test this code?

Expecting some minor snapshot changes

daibhin avatar Feb 16 '24 11:02 daibhin

📸 UI snapshots have been updated

121 snapshot changes in total. 0 added, 121 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Feb 16 '24 11:02 posthog-bot

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Feb 16 '24 11:02 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Feb 16 '24 11:02 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Feb 16 '24 11:02 posthog-bot

Size Change: +1.01 kB (0%)

Total Size: 864 kB

Filename Size Change
frontend/dist/toolbar.js 864 kB +1.01 kB (0%)

compressed-size-action

github-actions[bot] avatar Feb 16 '24 12:02 github-actions[bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Feb 16 '24 12:02 posthog-bot

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Feb 16 '24 12:02 posthog-bot

@PostHog/noteforce-3000 @corywatilo there's a ton of UI changes because of the icons being used so widely. I've added comments to the most relevant ones so probably worth focusing on those. I've gone through the rest and they are just more examples of the same issues highlighted in the comments

daibhin avatar Feb 16 '24 17:02 daibhin

📸 UI snapshots have been updated

127 snapshot changes in total. 0 added, 127 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Feb 19 '24 15:02 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Feb 19 '24 16:02 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Feb 19 '24 16:02 posthog-bot