posthog

posthog copied to clipboard

Reame
Issues

feat(surveys): replace surveys preview

Open liyiy opened this issue 2 years ago • 5 comments

Problem

Changes

remake of https://github.com/PostHog/posthog/pull/20280

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Feb 13 '24 19:02 liyiy

📸 UI snapshots have been updated

28 snapshot changes in total. 0 added, 28 modified, 0 deleted:

chromium: 0 added, 28 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Feb 15 '24 18:02 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Feb 15 '24 20:02 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Feb 15 '24 21:02 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Feb 15 '24 21:02 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Feb 15 '24 21:02 posthog-bot

Size Change: 0 B

Total Size: 1.04 MB

ℹ️ View Unchanged

Filename	Size
`frontend/dist/toolbar.js`	1.04 MB

_{compressed-size-action}

Feb 21 '24 00:02 github-actions[bot]

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Feb 21 '24 02:02 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Feb 29 '24 07:02 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Mar 08 '24 07:03 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Mar 19 '24 07:03 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Mar 28 '24 07:03 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Apr 08 '24 07:04 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Apr 16 '24 07:04 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Apr 24 '24 07:04 posthog-bot

📸 UI snapshots have been updated

18 snapshot changes in total. 0 added, 18 modified, 0 deleted:

chromium: 0 added, 18 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Apr 25 '24 09:04 posthog-bot

📸 UI snapshots have been updated

18 snapshot changes in total. 0 added, 18 modified, 0 deleted:

chromium: 0 added, 18 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Apr 25 '24 11:04 posthog-bot

Changes:

Fixed guardAvailableFeature used for triggering subscription modal (was moved to another logic in the meantime)
Removed e2e test for the open-ended answer choice. This field is currently not getting auto-selected on text input, which is not a great UX, but we can live with it for a bit longer. Fixing this is beyond the scope of this sprint, but I've created an issue for it.
Adjusted rendering (see https://github.com/PostHog/posthog-js/pull/1157)

Apr 26 '24 10:04 jurajmajerik

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 4 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Apr 26 '24 10:04 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Apr 26 '24 10:04 posthog-bot

One blocking thing I mentioned in the other PR: The preview hides the 'save as draft' button. Otherwise, will give it a final test once the other PR is merged, should be ready to go right after 👍

Apr 26 '24 11:04 neilkakkar

Ready for the final check!

Apr 29 '24 11:04 jurajmajerik

📸 UI snapshots have been updated

13 snapshot changes in total. 0 added, 13 modified, 0 deleted:

chromium: 0 added, 13 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Apr 29 '24 11:04 posthog-bot

Nice!

Long names bork preview -> .whitespace-nowrap seems to be the sus class

html links seem to show up red in the preview for some reason -> - ah most probs because posthog styles override the preview styles

We should center the preview ->

CSAT emojis look nicer on prod -> (this is prod) and local ->

Seems pretty good other than this 👍

Apr 29 '24 12:04 neilkakkar

📸 UI snapshots have been updated

12 snapshot changes in total. 0 added, 12 modified, 0 deleted:

chromium: 0 added, 12 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Apr 29 '24 12:04 posthog-bot

I've fixed the alignment issues. Can we leave the color of the CSAT emoji for a follow-up? It seems it has to do with how we're attaching stylesheets, but debugging in the current workflow is 😩

I've confirmed the colors in the edit form and in the live survey are working correctly.

Apr 29 '24 13:04 jurajmajerik