fix(insights): edit source

[mariusandra]

trafficstars

Problem

You could view the source behind an insight for a while now, but you couldn't edit it. The button did nothing.

Changes

Now the button also takes effect.

How did you test this code?

Locally in the browser

[thmsobrmlr]

The check there is actually necessary. Try e.g. saving an insight. Don't know a better fix off the bat though and would need to dig deeper (potentially very deep) for a fix.

[github-actions[bot]]

Size Change: 0 B

Total Size: 2.22 MB

ℹ️ View Unchanged

Filename	Size
frontend/dist/toolbar.js	2.22 MB

_{compressed-size-action}

[mariusandra]

Yeah, I was afraid it looked too simple.

Should we start the process of moving off of "filters" even before all insights are migrated? Would that help in this case?

[thmsobrmlr]

Yeah, I was afraid it looked too simple.

Should we start the process of moving off of "filters" even before all insights are migrated? Would that help in this case?

We could get rid off "filters" just frontend-side by using the filter_to_query method, identifying all places where filters are still used frontend side and replacing those.

[posthog-bot]

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

[posthog-bot]

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.