posthog
posthog copied to clipboard
fix: allow usage exceeded alert to be dismissed
Problem
Two changes:
- Add a dismissKey to the usage exceeded alert banner. I think it's annoying to have it be persistent. 1a. Along with this change, tweaked the billingAlert onClose logic so the logic for showing the close button will work.
- Tweaked the product intro margins so it doesn't sit flush against alerts.
https://github.com/PostHog/posthog/assets/21014901/cf525e64-e944-4df1-89b1-b37d50bb97e5
Changes
đ Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Hey @xrdt! đ This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.
Size Change: +42 B (0%)
Total Size: 864 kB
âšī¸ View Unchanged
Filename | Size | Change |
---|---|---|
frontend/dist/toolbar.js |
864 kB | +42 B (0%) |
đ¸ UI snapshots have been updated
2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
-
chromium
: 0 added, 2 modified, 0 deleted (diff for shard 1) -
webkit
: 0 added, 0 modified, 0 deleted
Triggered by this commit.
Does this hide it forever? What if they go over their limit the next month?
That's a good point. I've updated it so we reset the dismissKey if the usageExceeded check is not triggered.
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
-
chromium
: 0 added, 0 modified, 0 deleted -
webkit
: 0 added, 1 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
-
chromium
: 0 added, 0 modified, 0 deleted -
webkit
: 0 added, 1 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
-
chromium
: 0 added, 0 modified, 0 deleted -
webkit
: 0 added, 1 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
-
chromium
: 0 added, 0 modified, 0 deleted -
webkit
: 0 added, 1 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
-
chromium
: 0 added, 0 modified, 0 deleted -
webkit
: 0 added, 1 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
-
chromium
: 0 added, 0 modified, 0 deleted -
webkit
: 0 added, 1 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
-
chromium
: 0 added, 1 modified, 0 deleted (wasn't pushed!) -
webkit
: 0 added, 1 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
-
chromium
: 0 added, 0 modified, 0 deleted -
webkit
: 0 added, 1 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
-
chromium
: 0 added, 0 modified, 0 deleted -
webkit
: 0 added, 1 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
-
chromium
: 0 added, 0 modified, 0 deleted -
webkit
: 0 added, 1 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
218 snapshot changes in total. 0 added, 218 modified, 0 deleted:
-
chromium
: 0 added, 110 modified, 0 deleted (diff for shard 1, diff for shard 2) -
webkit
: 0 added, 108 modified, 0 deleted (diff for shard 2)
Triggered by this commit.
đ¸ UI snapshots have been updated
218 snapshot changes in total. 0 added, 218 modified, 0 deleted:
-
chromium
: 0 added, 110 modified, 0 deleted (diff for shard 1, diff for shard 2) -
webkit
: 0 added, 108 modified, 0 deleted (diff for shard 2)
Triggered by this commit.