posthog icon indicating copy to clipboard operation
posthog copied to clipboard

feat(hogql): time to convert funnel

Open thmsobrmlr opened this issue 1 year ago â€ĸ 3 comments

Problem

Funnels need to be converted to HogQL (see the funnels section in https://github.com/PostHog/meta/issues/130).

Changes

  • Adds support for time-to-convert funnels, thereby also.
  • Adds hogql support for "least" and "greatest" functions.
  • Explicitly types funnel results.

Things that aren't as nice as they could be

  • The clickhouse query explodes, as aliased tables get inlined (see snapshots).
  • The query was refactored to use a JOIN ON ... instead of a JOIN USING ..., as HogQL doesn't support USING yet and I wanted to get this over the line.

How did you test this code?

Converted existing tests for the HogQL implementation

thmsobrmlr avatar Feb 12 '24 09:02 thmsobrmlr

Size Change: +221 B (0%)

Total Size: 2.22 MB

â„šī¸ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 2.22 MB +221 B (0%)

compressed-size-action

github-actions[bot] avatar Feb 12 '24 09:02 github-actions[bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Feb 14 '24 13:02 posthog-bot

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar Feb 14 '24 16:02 posthog-bot