posthog icon indicating copy to clipboard operation
posthog copied to clipboard

📘 Notebooks Megaissue

Open benjackwhite opened this issue 1 year ago • 5 comments

Must have

  • [x] Auto-saving that 100% works
  • [x] Clash detection when editing / Handle error state if there is a conflict when saving (overwrite or revert)
  • [x] Floating editor for Nodes in Notebook ~from 3000 sidebar~ - opens via a button
  • [ ] Edit insights in Notebooks
    • [x] Get main editing controls into the sidebar
    • [ ] Get other controls in (refresh, time period etc.)
    • [ ] Fix stylings to make sure the padding and resizing works (@thmsobrmlr )
  • [x] Editing of Events / Persons table
  • [x] AddToNotebook button - simple popover to select which Notebook (or create a new one)
  • [x] Search Notebooks from all places (Top search bar, notebook popover) (https://github.com/PostHog/posthog/pull/17398)
  • [x] Transcription notes for Recording
    • [x] Append a comment below a recording when inside a notebook
    • [x] Suggest a timestamp node that can be tabbed to accept after pressing Enter on a previous timestamped comment
    • [x] Offer to open notebooks containing comments when clicking "Comment" on a recording outside a notebook. Alternatively a simpler option would be to just focus the notebook and add a comment if open & contains a recording
    • [x] Play recording in notebook from position of timestamp after creation
    • [x] Add a playlist support for comments
  • [x] Playlist UI fix
  • [x] Timestamp component for recording notes
  • [x] Slash-hog - slash commands
  • [x] Automatic link detection
    • [x] Fix links being always opened in new tab due to this
    • [x] Open external links in a new tab
    • [x] Have separate styling for PH links (could we name the resource)
    • [x] Sidebar the notebook and navigate to the link if PH link
    • [ ] Opening a resource from a different project fails
  • [x] Re-think drag and drop UX (maybe with design input)
    • [x] Discoverability - add to Notebook template thing
    • [x] Dropzone above or below for "Choose notebook" with clever reaction to mouse location
  • [x] Feature Flag Node
  • [x] Persons Node
  • [x] Group Node
  • [x] Cohort Node
  • [x] Fix issues related to RecordingsModal popup
  • [x] Add storybook
  • [x] New notebook should have multiple lines so that if they click below the heading they can do something (a la Notion)
  • [x] Persistent file history
  • [ ] Add button can solve new and existing resources (mixture of slash command and @ command)
  • [x] Move to the sidebar
  • [ ] Known bugs
    • [x] Insertion suggestions overlap button actions - https://github.com/PostHog/posthog/pull/18135 @daibhin
    • [x] Cannot insert content between two nodes - https://github.com/PostHog/posthog/pull/18248 @daibhin
    • [ ] Node content is selected when a node is selected preventing text selection
  • [ ] Add empty state prompts @daibhin

Future priorities

Done

  • [x] Add text editing toolbar
  • [x] Alternative to "pin" which adds a recording below the playlist
  • [x] Intelligent search - search and filter across title and content
  • [x] Editable node titles
  • [x] Deep-dive controls (replay takes you to a graph which takes you to persons etc.)

Under consideration...

  • [ ] Cached results (needed for Sharing, Table of Contents and static Notebooks)
    • [ ] Cached / Point-in-time insights (i.e. no refreshing of data unless manually requested)
  • [ ] Notebook preview - remove things like Persons modal in favour of Notebook "preview" that can be turned into full notebook with one click
  • [ ] Extended insights - things like "Detailed results" that normal insights currently have
  • [ ] Table of Contents
  • [ ] Labels (or something like it - folders etc.)
  • [ ] Official templates
    • [ ] Custom templates
  • [ ] Sharing - different modes, e.g. "pages" style
  • [ ] Everything has a Notebook - Person, Group, Cohort, Events, Actions, Flags etc.
  • [ ] Configuration of controls to be shown even in view mode.
  • [ ] Keyboard shortcuts everywhere
  • [ ] Global notebook variables
  • [ ] Add "cheatsheet" popup for a notebook for common commands, and how to drag and drop etc.
  • [ ] Ability to swap from Widget to simple link (and vice versa?)
  • [ ] Comments
    • [ ] Allow commenting on a widget or notebook text
    • [ ] Mentions
    • [ ] Activity panel feed of your comments / mentions
    • [ ] Replies, emoji reactions... etc.
  • [ ] Canvas mode
    • [ ] Rebuild PostHog interface in Notebooks (e.g. Surveys analytics UI)
    • [ ] "Explore" page as default home
  • [ ] Replace dashboards with Notebooks
    • [ ] Multiple widgets in a row
    • [ ] Resizeable widths
    • [ ] (Additional other features listed here like cached results, variables etc.)
  • [ ] AI - Auto-suggest notebook content from existing data

For preview release

  • [x] Fix up background persistence logic
  • [x] Make it clearer items that are draggable to the notebook
  • [x] Add instrumentation
  • [x] Make size of notebook draggable
  • [x] Add intro to notebooks "notebook"
  • [x] Improve empty state of a notebook
  • [x] Fix fresh load issue with notebook open in sidebar and main view (same logic, different editor ref)

benjackwhite avatar May 23 '23 15:05 benjackwhite

My own observations from testing on 06/06:

  1. The hedgehog in hedgehog mode jumps a lot when typing, because it jumps when pressing space. It's a bit too much.
  2. I can't wait for a smaller navigation. Because when I am on my Mac screen, I can't view the playlist + the player + the notebook. So I always have to close the notebook to go to the next recording (autoplay is not good, because there are so many PostHog people amongst early users)
  3. When I go from the notebook to the playlist with my cursor, I naturally pass the events sidebar, so it always opens the events overlay, which is annoying
  4. When I drag a recording to the bottom of a notebook, it is annoying to add more content below. Because I can't click at the bottom of the recording and a new line appears. And I can't click next to the recording, because that only opens app the events overlay. So I have to click above the recording and then use the right arrow to go all the way past the recording
  5. For a recording, it would be nice to start at a timestamp or link to a timestamp in the notebook, because often times, you want to show a specific thing
  6. Now that I have created my notebooks with observations, I wish there would be a share button available in the split screen notebook
  7. It would be nice to click the title of the pinned notebook to open the notebook in the /notebooks URL

annikaschmid avatar Jun 06 '23 09:06 annikaschmid

I just accidentally overwrote the example notebook. Here is how I did it:

  1. I opened the notebook in the sidebar
  2. It opened some recent notebook, so far, all as expected
  3. Then I clicked the notebook name, I got a drop down and clicked "new notebook"
  4. I got a default notebook that had lots of instructions on how to use it. I thought "Oh cool, that is a nice way of telling users how to use this thing".
  5. Because I knew how to use this things, I pressed "command" + "A" and "command" + "X" to clear the notebook
  6. I renamed the notebook and added my content
  7. When I went to the notebook list to share my notebook, I was confused why Ben created it 5 days ago
  8. Then I realised what happened

annikaschmid avatar Jun 06 '23 10:06 annikaschmid

Here is my notebook watching recordings of users who use notebook, including observations: https://app.posthog.com/notebooks/OVCujg3U

annikaschmid avatar Jun 06 '23 10:06 annikaschmid

There seems to be a bug with turning a specific text into an H2 (##), I tried it both from the pinned sidebar as well as from the notebook in fullscreen. Here is the recording: https://app.posthog.com/recordings/1888ffe12ab129b-094ff95bc32afb-1d525634-16a7f0-1888ffe12ac3293?t=3250

annikaschmid avatar Jun 06 '23 10:06 annikaschmid

It'd save time to have a "copy" button to create a new notebook from an existing one.

mavericreal avatar May 01 '24 04:05 mavericreal