posthog icon indicating copy to clipboard operation
posthog copied to clipboard

fix: puts a pay gate on the description field

Open pauldambra opened this issue 2 years ago • 3 comments

Problem

Closes #13707

Changes

Adds a pay gate to the modal

permissioning but not collaboration

Screenshot 2023-01-13 at 13 00 31

neither permissioning nor collaboration

Screenshot 2023-01-13 at 13 00 10

collaboration but not permissioning

Screenshot 2023-01-13 at 12 55 40

both collaboration and permissioning

Screenshot 2023-01-13 at 12 54 35

How did you test this code?

running locally

pauldambra avatar Jan 13 '23 13:01 pauldambra

Two pay gates in one modal seems a bit overkill though, maybe we just shouldn't show the description field during dashboard creation if it's gated?

Twixes avatar Jan 13 '23 14:01 Twixes

Two pay gates in one modal seems a bit overkill though, maybe we just shouldn't show the description field during dashboard creation if it's gated?

Hmmm 🤔 makes it harder for the user to discover but you can get that feedback from a created dashboard...

pauldambra avatar Jan 13 '23 15:01 pauldambra

Yeah, exactly, I think it's enough if we show that descriptions exist by just having that on the actual dashboard.

Twixes avatar Jan 13 '23 16:01 Twixes

updated to hide the field instead

without collaboration with collaboration
Screenshot 2023-01-13 at 18 25 00 Screenshot 2023-01-13 at 18 24 43

pauldambra avatar Jan 13 '23 18:01 pauldambra