posthog icon indicating copy to clipboard operation
posthog copied to clipboard

fix: person prop parsing && autocomplete on props

Open paolodamico opened this issue 3 years ago • 1 comments

Problem

  • There was a bug in which we were ignoring the proper parsing of properties when adding/editing from the UI (i.e. boolean, null, number)
  • UX issue with autocomplete, browser suggestions for this are way off as these are very specific names.

Changes

  • Saved properties to the DB will now reflect the proper type and not default to string for everything.
  • When editing/adding a property, the inputs will no longer autocomplete or autocapitalize.

How did you test this code?

I'll be honest I didn't. Very straightforward changes imo.

@mariusandra back to PRs over issues 😉

paolodamico avatar Jan 13 '23 11:01 paolodamico

fyi seems like some Ubuntu mirrors are down, just a matter of re-running the failing tests

paolodamico avatar Jan 13 '23 11:01 paolodamico

thx Marius! awaiting merge now, hope to be seen here more frequently

paolodamico avatar Jan 14 '23 18:01 paolodamico

There's some mess happening with github actions (sounds familiar?). I'll close this PR and re-open one with the same changes... That's probably the easiest way forward right now 😅

mariusandra avatar Jan 16 '23 09:01 mariusandra

😆 vaguely familiar, sg!

paolodamico avatar Jan 16 '23 09:01 paolodamico