PostHog
feat(data-exploration): errors in data table
Problem
The data exploration events table swallowed all errors. No longer!
Changes
Before:
After:
Questions
I don't think we're exposing anything secret by passing on the ClickHouse error. However I don't know. Could we leak credentials or anything else this way? 🤔
How did you test this code?
Added tests for the backend. Checked the frontend in the browser.
Perhaps we could use posthog.errors.code.lookup_error_code() to only pass on errors like SYNTAX_ERROR, ILLEGAL_TYPE_OF_ARGUMENT, TYPE_MISMATCH, and such (based on a whitelist)? The rest would be good old 500s.
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.