posthog icon indicating copy to clipboard operation
posthog copied to clipboard

feat: set export batch size based on plugin settings

Open xvello opened this issue 2 years ago • 1 comments

Problem

Sister PR to https://github.com/PostHog/plugin-scaffold/pull/52 and https://github.com/PostHog/s3-export-plugin/pull/22: exports to blob storage (s3 / gcs / snowflake) should use a higher batch size than the default 500, to improve throughput and reduce cost.

Changes

https://github.com/PostHog/posthog/pull/13481 hard an ad-hoc solution for s3, we're generalizing it, based on a signal given by the plugin itself.

Cannot deploy yet until the s3 changes are released to prod-us, in the meantime I'll leave it in draft.

How did you test this code?

xvello avatar Jan 04 '23 13:01 xvello

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar Jan 12 '23 07:01 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar Jan 20 '23 07:01 posthog-bot

Unblocked by merging https://github.com/PostHog/posthog/pull/13855 and manually fixing the S3 plugin URL on prod-eu. Rebased and ready for final review.

xvello avatar Jan 23 '23 10:01 xvello