posthog icon indicating copy to clipboard operation
posthog copied to clipboard

chore(e2e-vrt): start using git-lfs for storing reference images

Open thmsobrmlr opened this issue 3 years ago • 4 comments

Problem

We're storing the reference images for visual regression tests in git. Over time these might become large and with it our repo.

Note: Needs clarification how the workflow for contributors without git-lfs is.

Installation

brew install git-lfs
git lfs install

Changes

  • Uses git-lfs for visual regression testing images
  • This does not remove existing reference images from git history in order to not rewrite said history

How did you test this code?

This PR

thmsobrmlr avatar Dec 23 '22 11:12 thmsobrmlr

Hey @thmsobrmlr! 👋 This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

posthog-bot avatar Dec 23 '22 11:12 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar Jan 02 '23 07:01 posthog-bot

Annoyingly image diffs in this PR all show a "Unable to render rich display" error. :/

Twixes avatar Jan 02 '23 12:01 Twixes

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar Jan 10 '23 07:01 posthog-bot

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

posthog-bot avatar Jan 17 '23 07:01 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar Jan 26 '23 07:01 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar Feb 03 '23 07:02 posthog-bot

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

posthog-bot avatar Feb 10 '23 07:02 posthog-bot