posthog icon indicating copy to clipboard operation
posthog copied to clipboard

fix(funnels): Show cohort names when breaking down by cohorts

Open macobo opened this issue 3 years ago • 1 comments

Problem

Cohort names would not display when breaking down by cohorts in funnels. Instead, a random number would be shown.

Examples from current master: image image

Changes

Root cause of this was poor typing, which was fixed by:

  • calling formatBreakdownLabel with all required arguments and making these arguments mandatory
  • undoing wrapping added by getBreakdownStepValues to all breakdown values when rendering a breakdown value

Also fixed some incorrect typing

How did you test this code?

Screenshots: image image

macobo avatar Sep 19 '22 10:09 macobo

Fair enough – can you just add handling for "All Users"?

Twixes avatar Sep 20 '22 11:09 Twixes