posthog icon indicating copy to clipboard operation
posthog copied to clipboard

Property Pills stack vertically in ActivityLog Sentence Lists

Open pauldambra opened this issue 2 years ago • 0 comments

Bug description

viewed in feature flag

Screenshot 2022-08-04 at 09 56 42

viewed in history tab

Screenshot 2022-08-04 at 09 53 56

When a change in the activity log has more than one property pill they stack vertically. They should stack horizontally. Ideally separated by commas using the SentenceList component.

How to reproduce

  • change a filter with more than one property in a feature flag
  • view the activity log

Environment

  • [x] PostHog Cloud
  • [x] self-hosted PostHog, version/commit: please provide

Additional context

Thank you for your bug report – we love squashing them!

pauldambra avatar Aug 04 '22 08:08 pauldambra

@pauldambra Hi, is the issue available to work on?

gabrielelanzafamee avatar Aug 25 '22 08:08 gabrielelanzafamee

I'd missed the updates to #11263 . There are a couple of nits I'd like to address there but that is otherwise a fix to this.

Thanks for the offer of help @xjabr 🙌 . There are other PRs in good-first-issue that you can look at 🥇

pauldambra avatar Aug 25 '22 10:08 pauldambra