posthog icon indicating copy to clipboard operation
posthog copied to clipboard

fix(persons): Use encoded url for sceneUrl

Open neilkakkar opened this issue 2 years ago • 0 comments

Problem

We recently decoded person URLs in the path: https://github.com/PostHog/posthog/pull/10650

which led to decoded urls not loading events for persons, because the sceneUrl was different (one escaped, other not escaped), which meant urlToAction never ran, which meant events were never loaded.

Fixes https://github.com/PostHog/posthog/issues/10922

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

neilkakkar avatar Jul 22 '22 13:07 neilkakkar

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar Aug 11 '22 07:08 posthog-bot

Is this mergeable @neilkakkar?

Twixes avatar Aug 11 '22 08:08 Twixes