posthog-js icon indicating copy to clipboard operation
posthog-js copied to clipboard

Unify casing

Open Twixes opened this issue 5 years ago • 3 comments

Proposal

Currently original parts of the code use snake_case, while newer additions use pascalCase. It's JS convention though to use pascalCase in most cases and it might be a good idea to refactor at least exported things (that users see) with that convention in mind.

Upsides

The current mix doesn't look very professional and might be leaving a poor impression on developers wanting to use PostHog.

Downsides

This maneuver would leave quite a lot of these snake_case parts and nuking them is not really an option at this point, so they'd have to be left functioning, just deprecated – that wouldn't be good for code readability.

Twixes avatar Jul 02 '20 23:07 Twixes

Yeah, this is definitely something to do one day! We should have a good test suite before embarking on this journey though.

mariusandra avatar Jul 03 '20 07:07 mariusandra

This issue hasn't seen activity in two years! If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.

posthog-bot avatar Apr 05 '23 09:04 posthog-bot

This is still painfully relevant.

Twixes avatar Apr 05 '23 13:04 Twixes