posthog-js icon indicating copy to clipboard operation
posthog-js copied to clipboard

chore: upgrade rrweb to alpha.17

Open daibhin opened this issue 1 year ago • 2 comments

Changes

Trying something out...

Checklist

  • [ ] Tests for new code (see advice on the tests we use)
  • [ ] Accounted for the impact of any changes across different browsers
  • [ ] Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

daibhin avatar Oct 23 '24 09:10 daibhin

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Nov 4, 2024 11:35pm

vercel[bot] avatar Oct 23 '24 09:10 vercel[bot]

Size Change: +76.7 kB (+2.55%)

Total Size: 3.09 MB

Filename Size Change
dist/all-external-dependencies.js 204 kB +11 kB (+5.69%) 🔍
dist/array.full.js 353 kB +11 kB (+3.2%)
dist/array.full.no-external.js 352 kB +11 kB (+3.21%)
dist/module.full.js 353 kB +11 kB (+3.21%)
dist/module.full.no-external.js 352 kB +11 kB (+3.21%)
dist/recorder-v2.js 113 kB +10.9 kB (+10.68%) ⚠️
dist/recorder.js 113 kB +10.9 kB (+10.68%) ⚠️
ℹ️ View Unchanged
Filename Size
dist/array.full.es5.js 251 kB
dist/array.js 168 kB
dist/array.no-external.js 167 kB
dist/dead-clicks-autocapture.js 12.8 kB
dist/exception-autocapture.js 8.77 kB
dist/external-scripts-loader.js 2.19 kB
dist/main.js 169 kB
dist/module.js 168 kB
dist/module.no-external.js 167 kB
dist/surveys-preview.js 56.7 kB
dist/surveys.js 62.1 kB
dist/tracing-headers.js 1.33 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

github-actions[bot] avatar Oct 23 '24 14:10 github-actions[bot]

we were queueing https://github.com/PostHog/posthog-js/issues/1464 on these upgrades but 🤔

pauldambra avatar Oct 28 '24 08:10 pauldambra

i guess that this isn't working because postcss is already bundled in with rrweb, not being included by our bundler 🤔

pauldambra avatar Oct 28 '24 13:10 pauldambra

tested locally and can still record and playback.

the bundle size increase is pretty extreme but we can loop back and improve that once we have things fixed

pauldambra avatar Nov 02 '24 22:11 pauldambra

Screenshot 2024-11-02 at 23 31 05

holy cow that increase is almost all in the console recorder 🤯

pauldambra avatar Nov 02 '24 22:11 pauldambra

🤣 🤣 🤣 🤣 🤣 🤣 🤣 🤣 🤣 @daibhin search in the console recorder js for postcss 🤣 🤣 🤣 🤣 🤣 🤣 🤣 🤣 🤣

pauldambra avatar Nov 02 '24 22:11 pauldambra

i believe bundle size fix is in https://github.com/rrweb-io/rrweb/pull/1594

pauldambra avatar Nov 02 '24 23:11 pauldambra

🤣 🤣 🤣 🤣 🤣 🤣 🤣 🤣 🤣 @daibhin search in the console recorder js for postcss 🤣 🤣 🤣 🤣 🤣 🤣 🤣 🤣 🤣

Crikey! We might need to contribute our bundle size increase checker back to rrweb 😅 I should really never have been allowed to increase the size of that package so much in the first place

daibhin avatar Nov 03 '24 14:11 daibhin

@pauldambra genius!! I removed the postcss code from the console plugin and the package sizes are finally back in a place of reasonable increase. Want to do a little bit of cleanup given all the changes we've made in this PR but ultimately think we're good to ship this upgrade

daibhin avatar Nov 03 '24 14:11 daibhin