posthog-js
posthog-js copied to clipboard
'img' config option does not work
img
config option is supposed to create an image tag and do a request to the server based on the url in src attribute.
Sending the request almost works, except it doesn't encode the event name or properties into the url it generates.
Actually, sending data via XHR GET would fail for the same reason.
The bug is the same for both - we should put the data into the URL via args
: https://github.com/PostHog/posthog-js/blob/master/src/posthog-core.js#L409-L411
Haven't tested if this would work on posthog-side though.
@timgl @mariusandra thoughts on this? Shall we a) fix this or b) drop the unsupported behavior?
I'd drop. We're not really targeting IE8
or whoever anymore. Making a bunch of DOM nodes just to send GET
requests seems silly.
This issue hasn't seen activity in two years! If you want to keep it open, post a comment or remove the stale
label – otherwise this will be closed in two weeks.
This issue was closed due to lack of activity. Feel free to reopen if it's still relevant.
removed in #651