PostHog
Feature/189/session replay min duration
:bulb: Motivation and Context
#189
:green_heart: How did you test it?
WIP
:pencil: Checklist
- [ ] I reviewed the submitted code.
- [ ] I added tests to verify the changes.
- [ ] I updated the docs if needed.
- [ ] No breaking change or entry added to the changelog.
@marandaneto could you please review the implementation? Thanks! Would then go ahead with the test cases.
Hie @marandaneto just following up on this PR.
Sorry i am on pto this week so a bit slow to review, maybe @ioannisj or @pauldambra can take a look for now? Otherwise i will have a look within the next couple days
No problem. Take your time @marandaneto. Also, please feel free to mention me in other issues that you think I can contribute to. I have kept some time aside to make the hog hoggier!
No problem. Take your time @marandaneto. Also, please feel free to mention me in other issues that you think I can contribute to. I have kept some time aside to make the hog hoggier!
@karntrehan did another pass, let me know if something is unclear, I understand some parts might be tricky
@marandaneto I have made some changes basis your feedback. Please check.
It has helped me understand the code flow better. Thanks!
@marandaneto I have made some changes basis your feedback. Please check.
It has helped me understand the code flow better. Thanks!
Thanks @karntrehan , I am currently on an offsite with my team but will review asap.
@karntrehan left a few new comments, a few things to address but it's in the right direction.
Closing the issue as a part of large repository cleanup, due to it being inactive and/or outdated. Please do not hesitate to ping me if it is still relevant, and I will happily reopen and work on it. Cheers!