Popup-Maker icon indicating copy to clipboard operation
Popup-Maker copied to clipboard

Close button text missing when popups are imported

Open marklchaves opened this issue 3 years ago • 1 comments

Describe the bug

The text for the close button is missing after a popup is imported using the WordPress export and import tools.

Site information

Popup Maker version: 1.16.1

WordPress version: 5.7.2

PHP version: 7.3.5

Expected behavior

After a popup is imported, the text for the close button should be the same as the popup that was exported.

Current behavior

The text for the close button is missing. There's no close button text.

Steps to reproduce

  1. Export your popups (Tools > Export)
  2. Import your popups to another WordPress site (Tools > Import).
  3. Launch your popups.
  4. Verify the close button text is missing (not there).

Errors

None.

Additional context

See screen capture.

Popup_Focus_–_caught_my_eye_dev_v

marklchaves avatar Jun 01 '21 08:06 marklchaves

Hmm, so there are 2 things here to look at, the default close button text is set from the popup theme used by that popup.

Then a popup can have its own override value.

My guess is that the export with null value is being set to "" on export and thus on import is using the empty string to override the popup theme.

Might be worth modifying the output during the export to set that value to the one that should be rendered, so in this case maybe the export instead of null or '' would use the value from the current theme used by that popup instead.

danieliser avatar Jun 02 '21 02:06 danieliser