Popup-Maker
Popup-Maker copied to clipboard
Close button text missing when popups are imported
Describe the bug
The text for the close button is missing after a popup is imported using the WordPress export and import tools.
Site information
Popup Maker version: 1.16.1
WordPress version: 5.7.2
PHP version: 7.3.5
Expected behavior
After a popup is imported, the text for the close button should be the same as the popup that was exported.
Current behavior
The text for the close button is missing. There's no close button text.
Steps to reproduce
- Export your popups (Tools > Export)
- Import your popups to another WordPress site (Tools > Import).
- Launch your popups.
- Verify the close button text is missing (not there).
Errors
None.
Additional context
See screen capture.

Hmm, so there are 2 things here to look at, the default close button text is set from the popup theme used by that popup.
Then a popup can have its own override value.
My guess is that the export with null
value is being set to ""
on export and thus on import is using the empty string to override the popup theme.
Might be worth modifying the output during the export to set that value to the one that should be rendered, so in this case maybe the export instead of null or ''
would use the value from the current theme used by that popup instead.