Popup-Maker icon indicating copy to clipboard operation
Popup-Maker copied to clipboard

Implement automated deployment to wordpress.org

Open danieliser opened this issue 4 years ago • 3 comments

We can deploy tags off the master branch directly to wordpress.org.

Since we don't merge release/ branches or beta tags into master until they become official releases and are then tagged immediately using git flow, this works perfectly with our setups and allows automating management of readme changes, and assets such as banners can be added directly to the github repo.

  • [ ] https://github.com/10up/action-wordpress-plugin-deploy
  • [ ] https://github.com/10up/action-wordpress-plugin-asset-update

Possible Future Enhancements

  • [ ] Deployments should build dependencies and run other build routines prior to sending.

danieliser avatar Apr 11 '20 03:04 danieliser

@danieliser Should this be a dependency/sub-issue of #711 or should we remove this part from that issue?

I definitely think we should highly-consider adding this to the scope of 1.11 once we start defining its scope.

fpcorso avatar Apr 15 '20 18:04 fpcorso

It could be I guess.

danieliser avatar Apr 16 '20 00:04 danieliser

@fpcorso This should be a good starting point, just too scared to pull the trigger without being able to effectively test the final zip contents before letting them go to wordpress.org.

https://github.com/PopupMaker/Popup-Maker/blob/workflow-deploy-to-wp-org/.github/workflows/deploy-to-wordpress-org.yml

That is will our build processes hold up in the VM and properly include/exclude the right files?

I've been hesitant to merge it for that reason and haven't found a good way to test it. That said we are greatly simplifying our processes by moving to wp-scripts, npm & composer. But still a bit squeemish about just the first run until I know it comes out as a working plugin.

As for readme and asset updates, that could be done now.

danieliser avatar Jun 10 '20 19:06 danieliser