Popup-Maker icon indicating copy to clipboard operation
Popup-Maker copied to clipboard

Mixing Advanced & Standard conditions in a single OR block isn't working as expected

Open danieliser opened this issue 5 years ago • 1 comments

Currently if you add 2 standard conditions that both fail and a single advanced condition that would pass to an OR block it won't trigger the popup.

The issue is that the popup never makes it on the page once the condition group fails to return a true value.

Possible solution is to replace the call to standard conditions with their boolean response.

So in JavaScript conditions would be processed like.

[
   [
        false, // condition processed in PHP
        false, // condition processed in PHP
        {
             condition: "url_contains",
             search: "string",
             not_operand: false
        }
   ]
]

This should properly allow mixing standard & advanced condition logic without comprromise.

IF ( FALSE || FALSE || advanced_condition_callback() ) {

}

danieliser avatar Aug 22 '19 01:08 danieliser

@fpcorso The code for this is done, just needs ported from Ahoy.

danieliser avatar Dec 11 '20 07:12 danieliser