Popup-Maker icon indicating copy to clipboard operation
Popup-Maker copied to clipboard

Positioning Bug: Positioning bottom center on safari doesn't maintain position when the browser bars hide.

Open danieliser opened this issue 5 years ago • 7 comments

Positioning Bug: Positioning bottom center on safari doesn't maintain position when the browser bars hide.

This ticket concluded that the popup is being positioned at the bottom using CSS top positioning. Forcing bottom fixed it.

https://secure.helpscout.net/conversation/773215298/11145/#thread-2230331500

danieliser avatar Mar 13 '19 21:03 danieliser

Helped me

.pum-theme-xxx.pum-theme-cutting-edge #popmake-xxx.pum-container {
  top: auto !important;
  bottom: 0 !important;
  margin-bottom: 0;
}

webprom avatar Jun 28 '19 03:06 webprom

I believe thats a confrimation that this solution will work.

danieliser avatar Jun 28 '19 04:06 danieliser

not very smooth when safari bottom bar is hiding, but better than from top, because now when bottom bar is hiding, popup is not staying at the bottom at all.

webprom avatar Jun 28 '19 04:06 webprom

Try adding

.pum-theme-xxx.pum-theme-cutting-edge #popmake-xxx.pum-container {
  top: auto !important;
  bottom: 0 !important;
  margin-bottom: 0;
  transition: bottom .5s;
}

IDK if it will animate bottom on that scenario or not but worth a try to smooth it out.

danieliser avatar Jun 28 '19 04:06 danieliser

good idea! thanks.

webprom avatar Jun 28 '19 05:06 webprom

As this is a rare issue, punting this to v1.10 so we can decide exactly how we want to proceed. We are already planning to rewrite our positoning logic, so this could fall into that.

danieliser avatar Jan 20 '20 08:01 danieliser

Hi!

Finally found how to fix the issue with a popup jumps at the bottom.

I've disabled "fixed position" in popup settings > display > position. Then just added fixed position again from CSS below, and it stopped jumping when the bar is activating/hiding on iOS.

.pum-container { top: auto !important; bottom: 0px !important; margin: 0 !important; position: fixed !important; }

So this works perfectly now.

webprom avatar Aug 07 '22 19:08 webprom