Popup-Maker icon indicating copy to clipboard operation
Popup-Maker copied to clipboard

Remember the last settings tab open for each popup (store and retrieve by popup ID)

Open marklchaves opened this issue 5 months ago • 0 comments

Describe the feature request

This is related to https://github.com/PopupMaker/Popup-Maker/issues/975.

I love how Popup Maker remembers the last settings tab you were in now!

However, I expect Popup Maker to remember which settings tab I had open for each popup. I don't think we should override every popup's last open tab to the last popup edited.

For example,

  1. I edit the Close settings for popup 123 and then exit.
  2. I edit the Targeting settings for popup 456 and then exit.
  3. When I go back to edit popup 123, it should have the Close settings tab open.
  4. If I go back to popup 456, the **Targeting settings tab should be open.

Use case

Test Case 1: Separate browser tabs work OK

  1. I edited 2 popups at the same time in different tabs.
  2. In the first popup, I edited the Close button settings and saved (also worked w/o saving first).
  3. In the second popup, I edited Targeting and saved.
  4. I reloaded the both tabs. They displayed the correct last edited settings tab (respectively).

Test Case 2: Same browser tab last popup edited globally _overrides) the last edited settings tab

  1. I edited the first popup and opened the Advanced tab. Then, I went back to the list of popups.
  2. I edited the second popup and saw that the Advanced tab was open. I changed to the Targeting tab and went back to the list of popups.
  3. When I opened the first popup again in the same browser tab, the Targeting tab was open instead of the Advanced tab. I expected it to still be on the Advanced tab.

Example screenshots (if any)

marklchaves avatar Sep 24 '24 05:09 marklchaves