Popup-Maker icon indicating copy to clipboard operation
Popup-Maker copied to clipboard

Display the correct popup title in the `aria-labelledby` HTML attribute

Open marklchaves opened this issue 5 months ago • 0 comments

Describe the feature request

This is related to https://github.com/PopupMaker/Popup-Maker/issues/1077

After the v1.20.1 patch, I see that esc_attr( $labelledby ) isn’t mangling the title string anymore (b/c the getter is probably returning a string now?). That means popup IDs for popups with titles aren't randomly displayed in the HTML at the bottom of the page anymore.

But I still don’t see the actual popup title in the aria-labelledby HTML attribute when a popup has a title. Attached is what I see in the HTML with the latest patch.

If my popup's title is "My Forms Test Popup 490", shouldn’t that be something like “My Forms Test Popup 490”, for example? Or is that "pum_popup_title_nnn" showing up by design?

When I temporarily removed the esc_attr() call, the aria-labelledby had my valid popup title text.

Thanks! (edited)

Use case

Display the correct popup title in the aria-labelledby HTML attribute.

Example screenshots (if any)

DevTools_-_wildebeest-take_instawp_xyz_

marklchaves avatar Sep 24 '24 05:09 marklchaves