OneAxisGeometryReader
OneAxisGeometryReader copied to clipboard
Remove FIXME in reduce(value:nextValue:)
First of all, I would like to thank you for contributing this repository. Even though it's already late 2021, SwiftUI still has a lot of imperfections. I still need OneAxisGeometryReader
to avoid unwanted effects of the original GeometryReader
.
When I read your source code, I found a FIXME
tag here:
https://github.com/adtrevor/OneAxisGeometryReader/blob/579e35cbe61acf014e14a14c875a79aa5efc29e2/Sources/OneAxisGeometryReader/HorizontalGeometryReader.swift#L23
I believe this FIXME
can be safely removed, since the empty implementation is intended in this case.
I believe this FIXME can be safely removed, since the empty implementation is intended in this case.
I think you are right indeed! Thank you this has been fixed! 🙂
Even though it's already late 2021, SwiftUI still has a lot of imperfections. I still need OneAxisGeometryReader to avoid unwanted effects of the original GeometryReader.
Indeed! It's nice to know this package is useful. I might soon tag a v0.1 or v1.0. I believe I could also deprecate HorizontalGeometryReader
and VerticalGeometryReader
in favor of HGeometryReader
and VGeometryReader
, respectively (#4)