Pomelo.EntityFrameworkCore.MySql
Pomelo.EntityFrameworkCore.MySql copied to clipboard
PomeloFoundation
Call for Contributors
Pomelo.EntityFrameworkCore.MySql is looking for core contributors to help with to help with maintenance and upgrades for the MySql Entity Framework Core Driver to track EF Core Upstream Version 2.1 and beyond (see issue #514)
I have worked on the previous few minor and major upgrades, and they can take a fair amount of work. I am no longer using EF at my day job and do not have as much capacity as in times past to contribute. I can say that it is very fun and rewarding work, and that the EF Core team at Microsoft are amazing folks and responsive when I get completely stuck. I'm glad to still participate in code reviews and may try to contribute more as I find time.
EF Core performs upstream major, minor, or patch releases that can require re-work of provider code approximately every 6 months. An ideal core contributor would use both Entity Framework Core and MySQL often and have the time to spend the time interfacing with the EF Upstream team to understand upcoming changes. That being said, all contributions are welcome.
Thanks for everyone's support over the 1.5 years that I've been working on the project, I look forward to seeing what the community continues to do!
cc @yukozh @mguinness
Hi @caleblloyd , I'm a software engineer, I want to be a contributor to this project. How can I join the project? Thank you. email: [email protected]
Hi @ngochivinh - awesome! A good way to start is to fork the repository, then work on a branch to fix an open issue or feature. Once it is ready, open a pull request back to this repository and we will do a code review.
After doing some PRs, code reviews, and getting a good feel for the project we can start to look at granting access to maintainer rights on the repository. Thanks!
@caleblloyd @yukozh Does joining Open Collective make any sense for this project? It could be a way to compensate contributors for their time and effort working on the project.
They let any open source project with at least 100 stars on GitHub join under their umbrella where they will act as a host organization so that you can start collecting donations (both one-off and recurring) and paying expenses without the headache of setting up a 501(c)(3) and a formal structure. You just add a bunch of trusted admins and you can manage expenses and invoices. Open Collective holds the money for you.
Does joining Open Collective make any sense for this project?
I don't think it makes a lot of sense at this point, there are currently no expenses associated with this project that I know of. GitHub, TravisCI, AppVeyor, and MyGet are all free for open source projects. I like the idea of contributors supporting the project either as personal contributions or companies contributing developer time if their business depends on the project.
I'm starting to use Pomelo.EF.MySql and when I get on track maybe I can contribute. Let's see!
I would like to help with the 2.1 migration but... When I pull the f_2.1.0-preview branch and run locally it has 36 failing test. All of the failures are because of - "Message: System.InvalidOperationException : The property 'GeneratedTime.CreatedTimestamp' could not be mapped, because it is of type 'DateTime' which is not a supported primitive type or a valid entity type. "
Is this normal? I have dotnet core 2.1.300-rc1-008673 installed.
@T-rav please see https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/514#issuecomment-386756893 for the 2.1.0 upgrade thread. We are working in f_2.1.0-spec-tests branch right now, join the conversation about 2.1.0 work there!
Thanks, but even more test are failing on that branch. I am do not have confidence to make changes when code is broken.
I guess I will pick this up once the test are all green.
On Mon, 28 May 2018, 18:22 Caleb Lloyd [email protected] wrote:
@T-rav https://github.com/T-rav please see #514 (comment) https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/514#issuecomment-386756893 for the 2.1.0 upgrade thread. We are working in f_2.1.0-spec-tests branch right now, join the conversation about 2.1.0 work there!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/522#issuecomment-392565151, or mute the thread https://github.com/notifications/unsubscribe-auth/AFIqilA8vuRAEKNJAZS-AOBHYGHZI-uRks5t3CRIgaJpZM4TCQGB .
The challenge is to get all the tests for 2.1.0 to pass. Once all the tests are green it's likely that the upgrade will be complete. However there will be ongoing support issues that you can participate in afterwards.
We are going to have to ship the first RC with most functional tests turned off in CI due to failing tests in #552 It would be very helpful for contributors to work through those test failures, help find fixes, and open PRs.
To run all Functional Tests:
dotnet test -f netcoreapp2.1 -c Release test/EFCore.MySql.FunctionalTests
To run a single Functional Tests in order to zero-in on an issue:
dotnet test -f netcoreapp2.1 -c Release test/EFCore.MySql.FunctionalTests --filter "FullyQualifiedName=Namespace.ClassName.MethodName"
// example:
dotnet test -f netcoreapp2.1 -c Release test/EFCore.MySql.FunctionalTests --filter "FullyQualifiedName=Pomelo.EntityFrameworkCore.MySql.FunctionalTests.Scaffolding.MySqlDatabaseModelFactoryTest.Set_unique_for_unique_index"
@caleblloyd do you still need the contributor for the project Pomelo.EntityFrameworkCore.MySql? thanks.
@IAMRogerXi We're certainly still looking for additional contributors. To get started, take a look at help wanted issues.
@IAMRogerXi If you are still interested in contributing you could take a look at https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/698.
Sure. However, I notice the issue is closed.?
On Fri, Oct 26, 2018 at 5:21 AM mguinness [email protected] wrote:
@IAMRogerXi https://github.com/IAMRogerXi If you are still interested in contributing you could take a look at #698 https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/698 .
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/522#issuecomment-433210076, or mute the thread https://github.com/notifications/unsubscribe-auth/AL-m6_QIoVtJfcXdBumST4dLaDdo54Hcks5uoitJgaJpZM4TCQGB .
As a reminder to any potential contributors, any issues with the up-for-grabs label is a good way to help out.
In the past 3 months only 10 PR's were created with many open issues needing attention. Any help closing issues will be much appreciated.
@caleblloyd Are you still looking for contributors? I am willing to assist. if help is still required
@DavisSylvester yes we are! A good way to start is to fork the repository, then work on a branch to fix an open issue or feature. Once it is ready, open a pull request back to this repository and we will do a code review.
There will be a big lift that we need help with once EF Core Upstream 3.0.0 is published.
Hi, how can we see upstream changes of Microsoft ef core team? Are them public? Or should we read the ef core repository changes?
