20 tests failing due to missing implementation of inherited abstract member

[austinpapritz]

Steps to reproduce

Pull the current master branch of Pomelo.EntityFrameworkCore.MySql. Try to build it or run the EFCore.MySql.FunctionalTests tests.

The issue

I'm trying to run the tests before submitting a pull request, but this error is failing 20 tests.

Here is the error message:

'StoredProcedureUpdateMySqlTest' does not implement inherited abstract member  
'StoredProcedureUpdateTestBase.Non_sproc_followed_by_sproc_commands_in_the_same_batch(bool)'Roslyn[CS0534]

Follow the error to StoredProcedureUpdateMySqlTest.cs: https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/blob/85824934325eb24cf2f2f0491ab7538775ed373f/test/EFCore.MySql.FunctionalTests/Update/StoredProcedureUpdateMySqlTest.cs#L16

Go to the definition of StoredProcedureUpdateTestBase and you'll see the missing abstract member:

   public abstract Task Non_sproc_followed_by_sproc_commands_in_the_same_batch(bool async);
   [ConditionalTheory]
   [MemberData("IsAsyncData", new[] { })]

If it's helpful, here is Microsoft EF Core's implementation.

They added the member on Nov 25, 2022 so I'm not sure how I'm the first to bring this up or if I'm just missing something. Any advice dealing with this error or should I just submit the pull request with the 20 failed tests?

Thanks for the help and I appreciate what y'all do.

Further technical details

MySQL version: 8.0.34 Operating system: Windows 11 Pomelo.EntityFrameworkCore.MySql version: 8.0 Microsoft.AspNetCore.App version: 7.0

[yukozh]

If it is not supported in MySQL, you can override the base case and add the attribute to skip it. Otherwise, we should support the function and make the case pass.