react-onclickoutside icon indicating copy to clipboard operation
react-onclickoutside copied to clipboard

Published 20 hours ago • verified publisher icon Pomax

Added reaction on disableOnClickOutside property change

Open todesstoss opened this issue 5 years ago • 5 comments

Added reaction on disableOnClickOutside property change. Activates on false, deactivates on true. Currently this property affects activation only on component’s mount phase

Fix for https://github.com/Pomax/react-onclickoutside/issues/317

todesstoss avatar Apr 13 '19 13:04 todesstoss

bump on this getting merged. i'm currently having to do a work around for the issue this addresses

dbratz1177 avatar Apr 18 '19 22:04 dbratz1177

This will need a rebase, but mostly because v6.9.0 was released in the mean time, which introduced just enough code to require manual code selection.

Pomax avatar Aug 11 '19 16:08 Pomax

Sorry for the delay. PR Updated

todesstoss avatar Oct 24 '19 08:10 todesstoss

please merge

tomasztomys avatar Mar 06 '20 23:03 tomasztomys

+1 on getting this merged.

bkingery avatar Dec 10 '21 23:12 bkingery

why closed?

tomasztomys avatar Oct 16 '23 13:10 tomasztomys

Because time moved on and React completely changed how things are "supposed to be done". Modern React is based on hooks, and https://github.com/Pomax/react-onclickoutside#functional-component-with-usestate-hook explains how to do what this HoC achieved for older versions of React.

Pomax avatar Oct 16 '23 14:10 Pomax